Makes the build smaller #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
regexcrate is making the library fairly large. Since we also usefancy_regex, havingregexfeels redundant. We only need it for its ability to operate over slices rather than just str, but with some refactoring of thevpathfunction I managed to avoid it entirely, making it possible to remove the dependency.Along with disabling unicode support for
fancy_regex, we get a ~1,7MiB binary (-1MiB). The remaining report shows thatfancy_regexis now the main overhead, but unfortunately I don't see a good way to fix it without removing support forpnpIgnorePattern(which is stored as a regex inside the JSON payload):Ref unrs/unrs-resolver#166